Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible bug in set_automatic_recalibration #5

Open
juergberinger opened this issue Mar 27, 2021 · 0 comments
Open

Possible bug in set_automatic_recalibration #5

juergberinger opened this issue Mar 27, 2021 · 0 comments

Comments

@juergberinger
Copy link

Line 119 in scd30.py in set_automatic_recalibration currently has

        self.i2c.writeto_mem(self.addr, self.SET_FRC, data, addrsize=16)

Based on the SCD30 interface description, shouldn't this be

        self.i2c.writeto_mem(self.addr, self.SET_ASC, data, addrsize=16)

i.e. writing SET_ASC (0x5306) instead of SET_FRC (0x5204)?
philrandal added a commit to philrandal/pico-examples that referenced this issue May 8, 2021
@philrandal
Fix auto recalibration
cc61d30 
Fix wrong parameter for self-calibration.

agners/micropython-scd30#5
yoshinari-nomura added a commit to yoshinari-nomura/pinot that referenced this issue May 26, 2022
@yoshinari-nomura
Possible bug in set_automatic_recalibration
d89a46a 
agners/micropython-scd30#5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@juergberinger