Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement authentication properly #4

Open
ahderman opened this issue May 3, 2020 · 0 comments
Open

Implement authentication properly #4

ahderman opened this issue May 3, 2020 · 0 comments
Labels

Comments

@ahderman
Copy link
Owner

ahderman commented May 3, 2020

Context

What is currently implemented:

  • Username and password are hard-coded in the backend
  • Nothing is stored in a database: neither username nor password nor session ids

This issue is about making sure that the username and password are stored in a database.

Acceptance criteria

  • The following are stored in a Dynamo DB table of users:
    • username,
    • salt
    • number of iterations of the hashing algorithm
    • hashed(password+salt)
  • The hashing algorithm is bcrypt (https://www.npmjs.com/package/bcryptjs)
  • On login, the provided password is checked against stored values using the same bcryptjs library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant