Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement session ids properly #5

Open
ahderman opened this issue May 3, 2020 · 0 comments
Open

Implement session ids properly #5

ahderman opened this issue May 3, 2020 · 0 comments
Labels
backend

Comments

@ahderman
Copy link
Owner

ahderman commented May 3, 2020

Context

Currently, the session id returned in the cookie by the /api/login endpoint is hard-coded to "123".
Instead, the session id should always be uniquely generated and stored in DB.

Acceptance Criteria

We should:

  • generate a unique session ID for every login and store it in a DB,
  • lookup the user by its session ID in the /api/authenticate and /api/logout endpoints
  • delete the session ID on logout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahderman