Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video player width to height ratio off on mobile #1

Open
scootyboots opened this issue Oct 4, 2020 · 1 comment
Open

Video player width to height ratio off on mobile #1

scootyboots opened this issue Oct 4, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@scootyboots
Copy link

Hey @ahmedsadman

I'm sure you're not at the stage in this project where you are optimizing for mobile, but in the meantime, one small fix could improve the mobile experience.

Right now the video player looks like this on mobile:
Screen Shot 2020-10-04 at 10 53 39 PM

You can see the height is too high for the width available on the screen so the majority of the video gets cut off.

I bet this could be fixed by not passing a height of 500px to the StyledPlayer component.

@ahmedsadman
Copy link
Owner

Hi, nothing related to mobile optimization has started yet. I will work onto it a bit later when I have made the core features more stable.

@ahmedsadman ahmedsadman added the good first issue Good for newcomers label Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants