Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestDeleteCookies fails with go 1.14.9 #26

Open
gaul opened this issue Sep 21, 2020 · 1 comment · May be fixed by #28
Open

TestDeleteCookies fails with go 1.14.9 #26

gaul opened this issue Sep 21, 2020 · 1 comment · May be fixed by #28

Comments

@gaul
Copy link
Contributor

gaul commented Sep 21, 2020 

$ go test
--- FAIL: TestDeleteCookies (0.00s)
    require.go:44:
                Error Trace:    handlers_test.go:460
                Error:          "[k3=v3]" does not contain "k1="
                Test:           TestDeleteCookies
FAIL
exit status 1
FAIL    github.com/ahmetb/go-httpbin    2.229s
@ahmetb
Copy link
Owner

ahmetb commented Sep 21, 2020

If you got a fix, it's appreciated! I haven't looked at the code in a while.

gaul added a commit to gaul/go-httpbin that referenced this issue Sep 21, 2020
@gaul
Check version more robustly in TestDeleteCookies
b9e3206 
Previously this failed due to the two-digit subversion.  Fixes ahmetb#26.
@gaul gaul linked a pull request Sep 21, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check version more robustly in TestDeleteCookies gaul/go-httpbin
2 participants
@ahmetb @gaul