Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot failing at macOS #164

Open
Windrushfarer opened this issue Feb 20, 2020 · 1 comment
Open

Snapshot failing at macOS #164

Windrushfarer opened this issue Feb 20, 2020 · 1 comment

Comments

@Windrushfarer
Copy link
Contributor

Windrushfarer commented Feb 20, 2020 •
edited

With run yarn test in master branch this test https://github.com/ai/size-limit/blob/master/packages/size-limit/test/run.test.js#L235 fails when use macOS
test screenshot
@ai
Copy link
Owner

ai commented Feb 20, 2020

Seems like we need to replace all tmp dirs instead only one here

https://github.com/ai/size-limit/blob/master/packages/size-limit/test/run.test.js#L38-L46

Do you have an idea how to fix it?

@pustovalov pustovalov mentioned this issue Mar 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ai @Windrushfarer