Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downstream deps causing issues during postinstall for scripts #280

Closed
rmarkins-godaddy opened this issue Feb 9, 2022 · 4 comments
Closed

Downstream deps causing issues during postinstall for scripts #280

rmarkins-godaddy opened this issue Feb 9, 2022 · 4 comments

Comments

@rmarkins-godaddy
Copy link

the estimo package which depends upon puppeteer-core is causing issues when doing an npm install as the script fails due to their exports package.json change. Here are both issues I have filed

mbalabash/estimo#36

puppeteer/puppeteer#7986
@ai
Copy link
Owner

ai commented Feb 10, 2022

What version we should lock?

@rmarkins-godaddy
Copy link
Author

rmarkins-godaddy commented Feb 10, 2022 •
edited

@ai 13.2.0 should be good enough for puppeteer

@ai
Copy link
Owner

ai commented Feb 10, 2022

I can lock only estimo version. If you know a solution, please send PR.

@rmarkins-godaddy
Copy link
Author

@ai looks like puppeteer has reverted their exports change and published a new patch for this so downstream estimo might be unblocked for now. Closing this issue unless something else comes up

@einSelbst einSelbst mentioned this issue Feb 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ai @rmarkins-godaddy