Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails if a file at the path provided in config does not exist. No way to opt out of this #314

Open
ryanflowers opened this issue Mar 3, 2023 · 1 comment

Comments

@ryanflowers
Copy link

Do you want to request a feature or report a bug?
Request a feature

What is the current behavior?
I am currently running this tool within an nx mono repo. Nx has the ability to only build based on affected changes. That being said there may be valid cases where the paths supplied to the size tool in the package file do not exist. For example I am pointing the size tool at the the app file like so.

"size-limit": [
{
"limit": "3.2 s",
"path": [
"dist/app1//.*//_app-.js"
]
},
{
"limit": "150 kB",
"path": [
"dist/app2/**/.
/**/_app-*.js"
]
}
]

As it stands if I have not changed my code I wont have a build output. This is not something easily known when running the size tool.

The issue is that size fails if the path provided does not exist. Would be great for this to be optional. Something like a flag I can provide to not fail size-limit --ignoreIfFileMissing

@ai
Copy link
Owner

ai commented Mar 3, 2023

Please send PR. If it does not increase code complexity, we can add this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants