Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ Tooling: Allow local website development without a Liveblocks key? #867

Closed
JoshuaKGoldberg opened this issue Jan 5, 2024 · 16 comments
Labels
enhancement New feature or request ✨ goal: improvement Improvement to an existing feature

Comments

@JoshuaKGoldberg
Copy link
Contributor

Right now, if you don't set a NEXT_PUBLIC_LIVEBLOCKS_PUBLIC_KEY environment key and then pnpm dev the website, the page throws an error in the terminal:

 ✓ Compiled / in 6s (3741 modules)
 ⨯ Error: Invalid Liveblocks client options. Please provide either a `publicApiKey` or `authEndpoint` option. They cannot both be empty. For more information: https://liveblocks.io/docs/api-reference/liveblocks-client#createClient
    at prepareAuthentication (file:///Users/josh/repos/million/node_modules/.pnpm/@liveblocks+core@1.5.0/node_modules/@liveblocks/core/dist/index.mjs:1449:9)
    at createAuthManager (file:///Users/josh/repos/million/node_modules/.pnpm/@liveblocks+core@1.5.0/node_modules/@liveblocks/core/dist/index.mjs:1298:26)
    at createClient (file:///Users/josh/repos/million/node_modules/.pnpm/@liveblocks+core@1.5.0/node_modules/@liveblocks/core/dist/index.mjs:6001:23)
    at eval (webpack-internal:///./liveblocks.config.ts:15:80) {
  page: '/'
}

...which gets shown as a blocking Next.js error modal:

Screenshot of a Next.js error modal showing the 'Invalid Liveblocks client options' error from the code block. Its source code block shows liveblocks.config.ts (5:28), from a call to a createClient function.

It'd be nice if we didn't need to have a Liveblocks account to run the website locally. Would you be open to letting the website run without one in dev mode? I'd be happy to send a PR that refactors this a bit to just log a warning! ❤️

Copy link

github-actions bot commented Jan 5, 2024

Thanks for opening this issue! A maintainer will review it soon.

@tobySolutions tobySolutions added enhancement New feature or request ✨ goal: improvement Improvement to an existing feature labels Jan 7, 2024
@skushagra9
Copy link

Hey, I was working on this, I logged a warning for the absence of the env variable
@tobySolutions , are you open to run the website like this in dev mode??

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label Feb 15, 2024
@JoshuaKGoldberg
Copy link
Contributor Author

🤔 this feels like an unnecessarily aggressive stale bot. It probably shouldn't close issues that aren't waiting on an external person, no?

@github-actions github-actions bot removed the Stale label Feb 16, 2024
Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label Mar 3, 2024
@JoshuaKGoldberg
Copy link
Contributor Author

bamp

@github-actions github-actions bot removed the Stale label Mar 4, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label Mar 20, 2024
@JoshuaKGoldberg
Copy link
Contributor Author

bibbity

@github-actions github-actions bot removed the Stale label Mar 21, 2024
Copy link

github-actions bot commented Apr 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label Apr 6, 2024
@JoshuaKGoldberg
Copy link
Contributor Author

bobbity

@github-actions github-actions bot removed the Stale label Apr 7, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label Apr 23, 2024
@JoshuaKGoldberg
Copy link
Contributor Author

boomp

Copy link

github-actions bot commented May 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label May 9, 2024
@JoshuaKGoldberg
Copy link
Contributor Author

bidoof

@github-actions github-actions bot removed the Stale label May 10, 2024
@ImLunaHey
Copy link

can someone change the stale bot my god..

@aidenybai
Copy link
Owner

Liveblocks GONE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ✨ goal: improvement Improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants