Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Million.js Lint Not Working #994

Open
1 task
Bader975 opened this issue Mar 17, 2024 · 25 comments
Open
1 task

Million.js Lint Not Working #994

Bader975 opened this issue Mar 17, 2024 · 25 comments
Labels
million-lint This issue is related to Million Lint

Comments

@Bader975
Copy link

Bader975 commented Mar 17, 2024

What version of million are you using?

V3.0.6

Are you using an SSR adapter? If so, which one?

none

What package manager are you using?

npm

What operating system are you using?

windows

What browser are you using?

Chrome

Describe the Bug

Million.js Lint not working
Screenshot 2024-03-17 072717

What's the expected result?

it's should give hits to speed up my React app

Link to Minimal Reproducible Example

none , no error

Participation

  • I am willing to submit a pull request for this issue.
Copy link

Thanks for opening this issue! A maintainer will review it soon.

@Bader975 Bader975 changed the title Million.js Lint Million.js Lint Not Working Mar 17, 2024
@lucarampi
Copy link

lucarampi commented Mar 18, 2024

Same problem.

My nextjs config file: (tryed with and without rsc, both auto mode)
image

yarn run dev cli messages
image

@AndreiTS
Copy link

Same problem here:
image

Info:

  • Windows 11
  • yarn: 4.1.1
  • vite: 5.1.6
  • @million/lint: 0.0.73

@Alcas1
Copy link

Alcas1 commented Mar 18, 2024

Same problem here:

  • Mac 14.3.1
  • NextJS 13.5
  • Yarn 3.3.0
  • @million/lint: 0.0.73

@oskarscholander
Copy link

Same! 👋

  • Mac Sonoma 14.2
  • Vite v5.0.12
  • Yarn 4.0.2
  • @million/lint: 0.0.73

@BaileyNepe
Copy link

I get this issue as well when running in a bun workspace, however when I run on a different app using npm and not in a workspace, the linting works fine.

@cold-world
Copy link

same

Windows 11
npm: 10.5.0
vite: 5.1.6
@million/lint: 0.0.73

@N0SAFE
Copy link

N0SAFE commented Mar 19, 2024

same

Windows 11
npm 10.2.5
next 14.1.3
@million/lint 0.0.73

@lxsmnsyc lxsmnsyc added the million-lint This issue is related to Million Lint label Mar 20, 2024
@EliKnoph
Copy link

Same here!

Windows 11
npm 10.2.4
vite 5.0.10
@million/lint: 0.0.73

@cold-world
Copy link

and also it makes errors with react key prop all over the app

@emedeirox
Copy link

Same

Windows 11
pnpm 8.15.5
vite 5.1.4
@million/lint: 0.0.73

@tobySolutions
Copy link
Contributor

Hmm, thank you all for coming here to report this. I have reported this team and it's currently being worked on. Appreciate it:

@giovanniincammicia
Copy link

Hi, mine is the same, but I have a vscode notification that says: "million lint is successfully installed...waiting for connection" and never disappears. I tried logging into: https://lint.million.dev, but it immediately says: "session expired, log in again".

To test the linter, I've used a client component with a useEffect that runs setState(v => v + 1) indefinitely, producing infinite re-renders. Is it a good test that million lint should be able to recognize?

@tobySolutions
Copy link
Contributor

Hi, mine is the same, but I have a vscode notification that says: "million lint is successfully installed...waiting for connection" and never disappears. I tried logging into: https://lint.million.dev, but it immediately says: "session expired, log in again".

To test the linter, I've used a client component with a useEffect that runs setState(v => v + 1) indefinitely, producing infinite re-renders. Is it a good test that million lint should be able to recognize?

We're currently working on this actually. A fix will be sent in the next patch of the Million lint release

Copy link

github-actions bot commented Apr 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label Apr 8, 2024
@brendon1555
Copy link

Has there been any progress on this? Particularly with it not working in a workspace?

@sudexp
Copy link

sudexp commented Apr 10, 2024

The same issue for me (react/vite, yarn, mac os) fixed with:

  1. yarn add -D million@latest
  2. yarn add -D @million/lint
  3. vite.config.ts:
    ...
    import million from 'million/compiler';
    import MillionLint from '@million/lint';

export default defineConfig({
plugins: [
...
react(),
million.vite({ auto: true }),
MillionLint.vite(),
],
...
});

@github-actions github-actions bot removed the Stale label Apr 11, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label Apr 27, 2024
@Alcas1
Copy link

Alcas1 commented Apr 27, 2024

Not stale

@github-actions github-actions bot removed the Stale label Apr 28, 2024
@J4v4Scr1pt
Copy link

J4v4Scr1pt commented Apr 29, 2024

Same as all the others.

Windows 10
pnpm 8.8.8
next 14.2.3
@million/lint 0.0.73

@cold-world
Copy link

The same issue for me (react/vite, yarn, mac os) fixed with:

  1. yarn add -D million@latest
  2. yarn add -D @million/lint
  3. vite.config.ts:
    ...
    import million from 'million/compiler';
    import MillionLint from '@million/lint';

export default defineConfig({ plugins: [ ... react(), million.vite({ auto: true }), MillionLint.vite(), ], ... });

this works with million lint but it gives a lot of errors in project like missing key props in react, react-hook-form and tanstack-query not working properly.

@Bader975
Copy link
Author

@cold-world how install Million.js lint on Next,js 14 ?

@tobySolutions
Copy link
Contributor

@cold-world how install Million.js lint on Next,js 14 ?

Hey there, just follow this: https://million.dev/docs/introduction

@jacksmethurst
Copy link

Hitting the same issue, any updates?

@oskarscholander
Copy link

Is there any new updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
million-lint This issue is related to Million Lint
Projects
None yet
Development

No branches or pull requests