-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Angular 8 #3
Comments
👍 I've upvoted to bring terser customization into angular's default builder, as this I'm finding this builder really useful for my project where I want to see which component is performing the logging. So I agree that support for angular 8 would be a good enhancement to implement soon. I'll take a look to see whether I can submit a PR to help this along 😄 |
Hello @keenondrums - do you have an idea of when the Angular 8 support will be released? Would like test this, our project was recently upgraded to Angular 8 and the |
Is it as simple as creating a PR with peerDependencies tweaked as follows?
If so, I can do that pretty easily? |
If the fix is in master, and you look at the recent commits, I doubt those are the only changes. Not too sure though |
@JAspeling, yes you are absolutely right, I didn't notice the latest commit which indeed contains more changes. |
Guys, the fix is indeed in master, but I didn't have time to test it. As soon as I do, I'll make it an official release. |
Just a heads up - I compiled the code using |
It seems it was complaining about the implementation being missing because However the issue seems to still persist. |
Upvoting! |
I published |
Hi @aigoncharov can you please give as some repo example how to use angular-builders to keep class names? |
@yantrab which version of Angular are you using? |
Angular 8 |
We are actually migrating our current codebase to be minify-friendly so it doesn't depend on relaxed terser options. That's the other option people have and actually should go for. Thanks for the plugin, but we are no longer using it :) |
In Angular 8, there were some changes in the builder API and it's no longer compatible with the new version besides
package.json
version requirements.Error:
The text was updated successfully, but these errors were encountered: