Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Band/PDOS zoom changes when delesecting some PDOS channel #351

Closed
giovannipizzi opened this issue Feb 15, 2023 · 4 comments
Closed

Band/PDOS zoom changes when delesecting some PDOS channel #351

giovannipizzi opened this issue Feb 15, 2023 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@giovannipizzi
Copy link
Member

Describe the bug
When I deselect/hide some PDOS channel, by clicking on them, very often the zoom changes.

To Reproduce
Steps to reproduce the behavior:

  1. Open a finished workflow, wait for the bands to load
  2. Click on one of the spin channels. Not always, but very often the zoom changes (see screenshots).

Expected behavior
The zoom should not change but remain the current one.

Screenshots
Before clicking:
before

After clicking to disable Sn:
after

Version (if known)

  • App version: [e.g. v23.02.0]
@giovannipizzi giovannipizzi added the bug Something isn't working label Feb 15, 2023
@giovannipizzi giovannipizzi added this to the v2023.10.0 milestone Mar 1, 2023
@dou-du
Copy link

dou-du commented Mar 28, 2023

@unkcpz Hi Jusong, I cannot reproduce the issue. It seems working fine with the latest version of widget-bandsplot. Could you help me to double check whether this issue is still exsiting? Thanks a lot.

@dou-du
Copy link

dou-du commented Mar 29, 2023

I think I understood the issue. When you click the PDOS, there is a small motion of the mouse, which trigges the drag to zoom function. This is a inner issue from "chartjs-plugin-zoom", which is not totally fixed yet.

chartjs/chartjs-plugin-zoom#256

@unkcpz
Copy link
Member

unkcpz commented Oct 9, 2023

We are not able to address this issue in the next release, I'll move it to the milestone v24.4.0

@unkcpz unkcpz modified the milestones: v2023.10.0, v2024.4.0 Oct 9, 2023
@unkcpz
Copy link
Member

unkcpz commented Jan 30, 2024

The widget will be replaced by #581, and will be released in v24.04.0.

@unkcpz unkcpz closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants