Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to app not working in Chrome browser in iOS #128

Open
ArialBlack opened this issue Sep 19, 2019 · 9 comments
Open

Link to app not working in Chrome browser in iOS #128

ArialBlack opened this issue Sep 19, 2019 · 9 comments
Milestone

Comments

@ArialBlack
Copy link

ArialBlack commented Sep 19, 2019

Steps to reproduce:

  1. Take iOS device
  2. Open Chrome browser
  3. Try to open app starting with https://apps.apple.com...

What happens: current page just reloaded. Looks like target="_blank" with this url in Chrome prevents iOS to catch link. Btw, link starting with https://itunes.apple.com.. works fine.

What should happen: You can add check: if iOS && Chrome && link starts with https://apps.apple.com... => delete attribute target="_blank"

@ain
Copy link
Owner

ain commented Sep 19, 2019

Reproduced. iTunes link malfunctions as well though.

This is indeed a very unfortunate behaviour by the corporate browser. No such failure is there in Safari or Firefox.

Thanks for reporting!

ain added a commit that referenced this issue Sep 19, 2019
To replicate issue described in #128
@mreinhart
Copy link

Is there a reason to open in a new window (target="_blank") for any device? There might be I just can't think of one at the moment.

@ain
Copy link
Owner

ain commented Oct 22, 2019

Good question @mreinhart.

The reasoning is legacy support which, depending on a particular Android setup, would see people navigating directly to Play Store page instead of a new tab.

Let's pick this change up for version 2 ("breaking" version).

@AleksandrLeontev
Copy link

@ain Still have this problem with Chrome (on Safari works good), even with v2 branch.
When you will add this fix to the repo? Or maybe do you have some hot fix?

@ain
Copy link
Owner

ain commented Dec 22, 2019

Thanks for the heads up @AleksandrLeontev, this is something that is in the works. There're also other features that would be launched in v2, making it a major (breaking) release. We have some clean-up to perform and some tests to adjust accordingly. That'll take a bit of time.

We're targeting 1st half of January for the v2.

@KameronJohnson
Copy link

@ain,
Any updates on this one? Everything works great except trying to open an App Store link from Chrome. Thanks.

@m41w4r3exe
Copy link

@ain,
thanks for the great lib.

Anyone found a fix or workaround for this until v2 is out?

@ain
Copy link
Owner

ain commented May 1, 2020

Sorry for the delay guys! This has been picked up again, please hold on for the update.

@ain ain removed the help wanted label Jul 22, 2020
ain added a commit that referenced this issue Jul 22, 2020
Fix #128 Link to app not working in Chrome browser in iOS
@chaseklingelzen
Copy link

Hi @ain , thanks for the great project! I wanted to make sure I understood the issue here correctly. Does smartbanner.js not work if a user is using an iOS device and a chrome browser?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants