Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support up-to-date botocore #1115

Merged
merged 2 commits into from
May 16, 2024
Merged

Support up-to-date botocore #1115

merged 2 commits into from
May 16, 2024

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented May 16, 2024 •
edited

Description of Change

This PR intends to improve general compatibility of aiobotocore within the Python ecosystem by bumping the dependency specification of botocore, as well as boto3 and awscli.

Assumptions

Upstream diff contains minor changes that require adjustments to the aiobotocore codebase.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details): closes upgrade botocore dependency to 1.34.98? #1114
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller self-assigned this May 16, 2024
@codecov Codecov
Copy link

codecov bot commented May 16, 2024 •
edited

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.33%. Comparing base (ea86e2b) to head (1c99b02).

Files Patch % Lines
aiobotocore/signers.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1115      +/-   ##
==========================================
- Coverage   86.34%   86.33%   -0.01%     
==========================================
  Files          62       62              
  Lines        5910     5913       +3     
==========================================
+ Hits         5103     5105       +2     
- Misses        807      808       +1
Flag Coverage Δ
unittests 86.33% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller force-pushed the bump-botocore branch 2 times, most recently from 2b30f2c to 09fa81d Compare May 16, 2024 10:40
@jakob-keller jakob-keller marked this pull request as ready for review May 16, 2024 10:53
@thehesiod thehesiod merged commit 2d6520b into aio-libs:master May 16, 2024
11 of 12 checks passed
@jakob-keller jakob-keller deleted the bump-botocore branch May 16, 2024 17:54
@jakob-keller
Copy link
Collaborator Author

@thehesiod: Thanks for the quick merge and release!

@tgpfeiffer
Copy link

Thank you for the upgrade!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehesiod thehesiod thehesiod approved these changes

Assignees

@jakob-keller jakob-keller

Labels
deps-update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade botocore dependency to 1.34.98?
3 participants
@jakob-keller @tgpfeiffer @thehesiod