Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_presign_sigv4 #768

Open
terricain opened this issue Feb 20, 2020 · 1 comment
Open

test_presign_sigv4 #768

terricain opened this issue Feb 20, 2020 · 1 comment

Comments

@terricain
Copy link
Collaborator

This is mainly for my own reference.

@thehesiod I have a feeling test_presign_sigv4 needs you to explicitly set the addressing style like

Config(s3={'addressing_style': 'path'})

Also https://github.com/aio-libs/aiobotocore/blob/master/tests/conftest.py#L43 generates invalid bucket names when used against real s3, we probably want to patch moto so it also complains

@thehesiod
Copy link
Collaborator

hmm this sounds like a bug in moto then no? then it will trickle down to us once they fix that. Did you already log a bug there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants