Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use events to reduce footprint where possible #774

Open
thehesiod opened this issue Feb 23, 2020 · 1 comment
Open

Use events to reduce footprint where possible #774

thehesiod opened this issue Feb 23, 2020 · 1 comment
Labels
enhancement

Comments

@thehesiod
Copy link
Collaborator

@dazza-codes had the great insight to notice that the event creating-client-class.* would enable use to remove the AioClientCreator._create_client_class method be replacing the base_classes parameter with our AioBaseClient override.

We should go over the codebase wherever simplifications like this are possible.
@thehesiod thehesiod mentioned this issue Feb 23, 2020
Open
@thehesiod
Copy link
Collaborator Author

we probably should wait for #659 to land so we have async events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thehesiod