Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dupclicate socket #282

Merged
merged 2 commits into from Apr 22, 2018
Merged

dupclicate socket #282

merged 2 commits into from Apr 22, 2018

Conversation

jettify
Copy link
Member

@jettify jettify commented Apr 22, 2018

No description provided.

@codecov
Copy link

codecov bot commented Apr 22, 2018

Codecov Report

Merging #282 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files           9        9           
  Lines        1161     1161           
  Branches      173      173           
=======================================
  Hits         1079     1079           
  Misses         53       53           
  Partials       29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c23879...c08f626. Read the comment docs.

@terrycain
Copy link
Collaborator

Damn, this fixed my issue when it worked during debugging and not during running it normally, at least it looks like it did :D.

Am interested to know how you thought of that? Down to experience, a google or was some logic applied?

@jettify
Copy link
Member Author

jettify commented Apr 22, 2018

Remembered that aiohttp did something like that, then found relevant code:
https://github.com/aio-libs/aiohttp/blob/a7bbaadd5e4d7eccafabd3221d1240a9aedf24d8/aiohttp/connector.py#L914-L919

@terrisgit
Copy link

This resolves the control-C weirdness I experienced with #280. I will be using this in pre-production tomorrow. Thank you.

@jettify jettify merged commit ee119e2 into master Apr 22, 2018
@jettify jettify deleted the dup-socket branch April 22, 2018 18:43
@jettify
Copy link
Member Author

jettify commented Apr 22, 2018

New version available on PyPI https://pypi.org/project/aiomysql/0.0.14/

@terrisgit
Copy link

This release is rock solid and fixes some intermittent problems with #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants