Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiled cache not working with SA executemany #375

Open
katajakasa opened this issue Jan 20, 2019 · 2 comments
Open

Compiled cache not working with SA executemany #375

katajakasa opened this issue Jan 20, 2019 · 2 comments

Comments

@katajakasa
Copy link

I've been poking at the sqlalchemy connections compiled cache. It seems to work just fine for normal queries, but anything that goes through executemany does not seem to get cached. My test case is bulk insert, which seems to be suspiciously slower than when using multiple cached single queries. After taking a look at aiomysql's saconnection, the executemany does not actually even implement the cache.

So, is this omission intentional or just a forgotten feature ? I can't think of a case where the caching would not work, but on the other hand, I'm a noob when it comes to *sql drivers :)

@aio-libs-bot
Copy link

GitMate.io thinks possibly related issues are #290 (Cannot make db -> python value conversion working with custom SA columns), #49 (create_pool can not work with async/await feature), #46 ('trans.rollback()' is not working correct), #158 (aiomysql enabled cache?), and #86 (Inconsistant results after insert using sa).

@katajakasa
Copy link
Author

I had some free time, so I wrote a fix which seems to be working: #376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants