Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import version from __init.py__ #388

Merged
merged 1 commit into from Feb 22, 2019
Merged

import version from __init.py__ #388

merged 1 commit into from Feb 22, 2019

Conversation

epooda
Copy link
Contributor

@epooda epooda commented Feb 22, 2019

I see the comment "# TODO somehow import version from _init_.py" in the connection.py.
Since A import B and B import A will cause cycle import, _init_.py has imported sth from conncetion, so I import version in the function inner to avoid the problem.

@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #388 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #388   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files           9        9           
  Lines        1180     1180           
  Branches      172      172           
=======================================
  Hits         1089     1089           
  Misses         64       64           
  Partials       27       27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66d8657...5b69889. Read the comment docs.

@asvetlov asvetlov merged commit 131fb9f into aio-libs:master Feb 22, 2019
@asvetlov
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants