Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/index.rst: Updated tutorial to native coroutines #437

Merged
merged 1 commit into from Sep 11, 2019

Conversation

Pradhvan
Copy link

This updates the old-styled @asyncio.coroutine -> async def coroutine and updates yield from -> await.

Closes #436

What do these changes do?

This PR updates the old-styled @asyncio.coroutine -> async def coroutine and updates yield from -> await keyword.

Are there changes in behavior for the user?

Yes

Related issue number

None

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

This updates the old styled @asyncio.coroutine -> async def coroutine and updates yield from -> await.

Closes aio-libs#436
@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #437 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #437   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files           9        9           
  Lines        1180     1180           
  Branches      172      172           
=======================================
  Hits         1089     1089           
  Misses         64       64           
  Partials       27       27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f8a6d...bec31e3. Read the comment docs.

@asvetlov asvetlov merged commit b16e5bd into aio-libs:master Sep 11, 2019
@asvetlov
Copy link
Member

Thanks!
Travis error is unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old style coroutines used the readthedocs
3 participants