make pool.release return future #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
What is motivation to wait releasing connection? |
|
Main reason, just to make sure we do not leave opened connections in background task, and all exception that happened there are raised in proper coroutine, otherwise in best case we will see exception in logs. |
jettify
added a commit
that referenced
this pull request
Jan 20, 2016
make pool.release return future
|
Thanks for reply. I got it. By the way, "This is NOT a coroutine." in docstring of |
|
Thanks for pointing. Yes, unfortunately documentation is outdated, updating is what I going to work on next. My plan is to move all examples and docs to python3.5 syntax and add section on new apis. Then work on PyMySQL 0.7 compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.