Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a shortcut for determining secure connections, now supporting unix sockets #695

Merged
merged 1 commit into from Jan 28, 2022

Conversation

Nothing4You
Copy link
Collaborator

@Nothing4You Nothing4You commented Jan 28, 2022

What do these changes do?

implement a shortcut for determining secure connections, now supporting unix sockets
ports PyMySQL/PyMySQL#696
ports check for server tls support for secure connections from PyMySQL/PyMySQL#353

Unix sockets are now internally considered secure.

Are there changes in behavior for the user?

sha256_password and caching_sha2_password should now work for unix sockets (pending tests from #686)

Related issue number

Fixes 673.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment to CHANGES.txt

@Nothing4You Nothing4You added pymysql pymysql-port Awaiting or implementing port of PyMySQL change labels Jan 28, 2022
@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #695 (8bb1e6f) into master (2955052) will decrease coverage by 0.02%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #695      +/-   ##
==========================================
- Coverage   85.70%   85.68%   -0.03%     
==========================================
  Files          12       12              
  Lines        2085     2088       +3     
  Branches      336      336              
==========================================
+ Hits         1787     1789       +2     
- Misses        228      229       +1     
  Partials       70       70              
Flag Coverage Δ
ubuntu-latest_3.7_mariadb-10.2 81.91% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.7_mariadb-10.3 81.91% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.7_mariadb-10.4 81.91% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.7_mariadb-10.5 81.91% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.7_mariadb-10.6 81.91% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.7_mariadb-10.7 81.91% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.7_mysql-5.7 82.79% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.7_mysql-8.0 84.70% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.8_mariadb-10.2 82.32% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.8_mariadb-10.3 82.32% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.8_mariadb-10.4 82.32% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.8_mariadb-10.5 82.32% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.8_mariadb-10.6 82.32% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.8_mariadb-10.7 82.32% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.8_mysql-5.7 83.18% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.8_mysql-8.0 85.01% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.9_mariadb-10.2 82.32% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.9_mariadb-10.3 82.32% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.9_mariadb-10.4 82.32% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.9_mariadb-10.5 82.32% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.9_mariadb-10.6 82.32% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.9_mariadb-10.7 82.32% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.9_mysql-5.7 83.18% <42.85%> (-0.03%) ⬇️
ubuntu-latest_3.9_mysql-8.0 85.01% <42.85%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiomysql/connection.py 82.70% <42.85%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2955052...8bb1e6f. Read the comment docs.

…ng unix sockets

ports PyMySQL/PyMySQL#696
ports check for server tls support for secure connections from PyMySQL/PyMySQL#353
@Nothing4You Nothing4You marked this pull request as ready for review January 28, 2022 18:06
@Nothing4You Nothing4You merged commit 8fe7e53 into master Jan 28, 2022
@Nothing4You Nothing4You deleted the pymysql-696 branch January 28, 2022 18:13
@Nothing4You Nothing4You linked an issue Jan 28, 2022 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pymysql pymysql-port Awaiting or implementing port of PyMySQL change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

caching_sha2_password full auth on MySQL 8.0 does not work over unix sockets
1 participant