Add unix socket tests #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configure custom socket path for mysql container, working around implicitly created volume folders being owned by root we should probably just not use service containers for this to avoid having to do this patching
Nothing4You
force-pushed
the
unix-socket-tests
branch
from
623ccd5
to
4feb22a
Compare
Codecov Report
@@ Coverage Diff @@
## master #696 +/- ##
==========================================
+ Coverage 85.68% 86.25% +0.57%
==========================================
Files 12 12
Lines 2088 2088
Branches 336 336
==========================================
+ Hits 1789 1801 +12
+ Misses 229 219 -10
+ Partials 70 68 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Run the entire test suite against unix sockets as well as over TCP.
This effectively runs every test twice against every DB version, once over unix socket, once over TCP.
This also implements passing arbitrary connection info to the test suite, allowing to run tests against multiple databases in the same test run.
It can later be expanded to run more databases in the same test run, which should allow us to launch containers for all databases in the same CI job (assuming CI VM resource limits permit that).
For that to be implemented however, the current workaround of passing DB versions via env var needs to be replaced.
Due to doing even more changes to the service containers with this it may be worth to just not use service containers at all in the future, launching custom containers by ourselves at an early step.
That may also benefit testing on other OS, as service containers are currently only supported on ubuntu.
Are there changes in behavior for the user?
No.
Related issue number
Fixes #664
Checklist
CHANGES.txt