Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated Pool.get #706

Merged
merged 1 commit into from Jul 10, 2022
Merged

Conversation

Nothing4You
Copy link
Collaborator

What do these changes do?

Deprecated method Pool.get was removed

Are there changes in behavior for the user?

Yes, see above.

Related issue number

no

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment to CHANGES.txt

@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #706 (798e7fd) into master (eb7250f) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
- Coverage   92.72%   92.62%   -0.11%     
==========================================
  Files          38       38              
  Lines        5570     5560      -10     
  Branches      944      941       -3     
==========================================
- Hits         5165     5150      -15     
- Misses        317      322       +5     
  Partials       88       88              
Flag Coverage Δ
ubuntu-latest_3.10_mariadb-10.3 89.13% <72.22%> (-0.15%) ⬇️
ubuntu-latest_3.10_mariadb-10.4 89.13% <72.22%> (-0.15%) ⬇️
ubuntu-latest_3.10_mariadb-10.5 89.11% <72.22%> (-0.15%) ⬇️
ubuntu-latest_3.10_mariadb-10.6 89.11% <72.22%> (-0.15%) ⬇️
ubuntu-latest_3.10_mariadb-10.7 89.11% <72.22%> (-0.15%) ⬇️
ubuntu-latest_3.10_mariadb-10.8 89.11% <72.22%> (-0.15%) ⬇️
ubuntu-latest_3.10_mysql-5.7 89.82% <72.22%> (-0.15%) ⬇️
ubuntu-latest_3.10_mysql-8.0 91.20% <94.44%> (-0.15%) ⬇️
ubuntu-latest_3.11-dev_mariadb-10.3 89.10% <72.22%> (-0.15%) ⬇️
ubuntu-latest_3.11-dev_mariadb-10.4 89.10% <72.22%> (-0.15%) ⬇️
ubuntu-latest_3.11-dev_mariadb-10.5 89.08% <72.22%> (-0.15%) ⬇️
ubuntu-latest_3.11-dev_mariadb-10.6 89.08% <72.22%> (-0.15%) ⬇️
ubuntu-latest_3.11-dev_mariadb-10.7 89.08% <72.22%> (-0.15%) ⬇️
ubuntu-latest_3.11-dev_mariadb-10.8 89.08% <72.22%> (-0.15%) ⬇️
ubuntu-latest_3.11-dev_mysql-5.7 89.78% <72.22%> (-0.15%) ⬇️
ubuntu-latest_3.11-dev_mysql-8.0 91.16% <94.44%> (-0.15%) ⬇️
ubuntu-latest_3.7_mariadb-10.3 88.52% <77.77%> (-0.16%) ⬇️
ubuntu-latest_3.7_mariadb-10.4 88.52% <77.77%> (-0.16%) ⬇️
ubuntu-latest_3.7_mariadb-10.5 88.50% <77.77%> (-0.16%) ⬇️
ubuntu-latest_3.7_mariadb-10.6 88.50% <77.77%> (-0.16%) ⬇️
ubuntu-latest_3.7_mariadb-10.7 88.50% <77.77%> (-0.16%) ⬇️
ubuntu-latest_3.7_mariadb-10.8 88.50% <77.77%> (-0.16%) ⬇️
ubuntu-latest_3.7_mysql-5.7 89.25% <77.77%> (-0.16%) ⬇️
ubuntu-latest_3.7_mysql-8.0 90.75% <100.00%> (-0.12%) ⬇️
ubuntu-latest_3.8_mariadb-10.3 89.17% <77.77%> (-0.15%) ⬇️
ubuntu-latest_3.8_mariadb-10.4 89.17% <77.77%> (-0.15%) ⬇️
ubuntu-latest_3.8_mariadb-10.5 89.15% <77.77%> (-0.15%) ⬇️
ubuntu-latest_3.8_mariadb-10.6 89.15% <77.77%> (-0.15%) ⬇️
ubuntu-latest_3.8_mariadb-10.7 89.15% <77.77%> (-0.15%) ⬇️
ubuntu-latest_3.8_mariadb-10.8 89.15% <77.77%> (-0.15%) ⬇️
ubuntu-latest_3.8_mysql-5.7 89.86% <77.77%> (-0.15%) ⬇️
ubuntu-latest_3.8_mysql-8.0 91.22% <100.00%> (-0.15%) ⬇️
ubuntu-latest_3.9_mariadb-10.3 89.03% <77.77%> (-0.15%) ⬇️
ubuntu-latest_3.9_mariadb-10.4 89.03% <77.77%> (-0.15%) ⬇️
ubuntu-latest_3.9_mariadb-10.5 89.01% <77.77%> (-0.15%) ⬇️
ubuntu-latest_3.9_mariadb-10.6 89.01% <77.77%> (-0.15%) ⬇️
ubuntu-latest_3.9_mariadb-10.7 89.01% <77.77%> (-0.15%) ⬇️
ubuntu-latest_3.9_mariadb-10.8 89.01% <77.77%> (-0.15%) ⬇️
ubuntu-latest_3.9_mysql-5.7 89.71% <77.77%> (-0.15%) ⬇️
ubuntu-latest_3.9_mysql-8.0 91.08% <100.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiomysql/pool.py 96.98% <ø> (-0.06%) ⬇️
tests/test_async_with.py 100.00% <ø> (ø)
tests/test_issues.py 86.30% <100.00%> (+0.63%) ⬆️
tests/test_pool.py 97.38% <100.00%> (ø)
tests/test_sha_connection.py 100.00% <100.00%> (ø)
tests/test_ssl.py 100.00% <100.00%> (ø)
aiomysql/utils.py 77.96% <0.00%> (-5.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7250f...798e7fd. Read the comment docs.

@Nothing4You
Copy link
Collaborator Author

based on the coverage report it should also be safe to remove _PoolConnectionContextManager.__aenter__ and _PoolConnectionContextManager.__aexit__.

when we add type annotations we can probably merge the various context managers into a single one like in aio-libs/aiopg#813 anyways.

@Nothing4You Nothing4You added this to the 0.2 milestone Feb 20, 2022
@Nothing4You Nothing4You force-pushed the remove-deprecated-pool.get branch 4 times, most recently from 8459477 to 2239d89 Compare April 15, 2022 01:47
@Nothing4You Nothing4You merged commit b21f0ed into master Jul 10, 2022
@Nothing4You Nothing4You deleted the remove-deprecated-pool.get branch July 10, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants