Fix SSL connection handshake charset not respecting client configuration #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
alviezhang
force-pushed
the
master
branch
2 times, most recently
from
904d966
to
647e8ab
Compare
1 task
|
thanks, see also #648 I'll review this later |
Codecov Report
@@ Coverage Diff @@
## master #776 +/- ##
==========================================
+ Coverage 92.74% 92.75% +0.01%
==========================================
Files 38 38
Lines 5558 5566 +8
Branches 942 943 +1
==========================================
+ Hits 5155 5163 +8
Misses 315 315
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Thanks, looks good. Could you please fix the flake failure and add a note into CHANGES.txt? |
|
@Nothing4You How do I add the changes to CHANGES.txt? In version 0.1.0 or create a new version? |
alviezhang
changed the title
|
add a new section like this please: Lines 4 to 5 in 2239d89 |
|
@Nothing4You Thanks for answering. I've already added a changelog to CHANGES.txt |
|
thanks |
andr-04
added a commit
to andr-04/aiomysql
that referenced
this pull request
May 13, 2022
* commit '8a32f052a16dc3886af54b98f4d91d95862bfb8e': (92 commits) Update changelog for 0.1.1 release (aio-libs#784) Bump pytest from 7.1.1 to 7.1.2 (aio-libs#781) XFail test_issue_36 for now to avoid failing for unrelated changes (aio-libs#779) Skip codecov uploads in scheduled daily tests (aio-libs#778) Bump codecov/codecov-action from 3.0.0 to 3.1.0 (aio-libs#777) Fix SSL connection handshake charset not respecting client configuration (aio-libs#776) Bump ncipollo/release-action from 1.9.0 to 1.10.0 (aio-libs#766) Bump actions/cache from 3.0.1 to 3.0.2 (aio-libs#771) Bump actions/download-artifact from 2 to 3 (aio-libs#765) Bump actions/upload-artifact from 2 to 3 (aio-libs#767) Update changelog for release (aio-libs#769) Checkout git source to access changelog for GitHub release creation Change next version to 0.1.0 in changelog Fix GHA badge in readme after aio-libs#734 (aio-libs#762) Fix SSCursor raising query timeout error on wrong query on MySQL DB (aio-libs#761) Specify explicit language for literal blocks in CONTRIBUTING.rst to reduce warnings in doc builds (aio-libs#760) fix `make checkrst` (aio-libs#759) Update sphinx requirement from <4.4.1,>=1.8.1 to 4.5.0 (aio-libs#751) Bump codecov/codecov-action from 2.1.0 to 3.0.0 (aio-libs#758) Bump actions/cache from 2.1.7 to 3.0.1 (aio-libs#752) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The SSL connection handshake character set is fixed to utf8, this PR is to fix that issue #775
Are there changes in behavior for the user?
Users should be able to establish SSL connections with the client charset parameter
Related issue number
#775
Checklist
CHANGES.txt