Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log exception #863

Merged
merged 2 commits into from Oct 23, 2022
Merged

Fix log exception #863

merged 2 commits into from Oct 23, 2022

Conversation

laozhp
Copy link
Contributor

@laozhp laozhp commented Oct 23, 2022

What do these changes do?

Fix log exception, when login mysql using sha256_password_auth, exception throw
TypeError: not all arguments converted during string formatting at connection.py:1012

            logger.debug(
                "Received public key:\n",
                self.server_public_key.decode('ascii')
            )

Are there changes in behavior for the user?

No.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Merging #863 (235e442) into master (5877a88) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #863   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files          36       36           
  Lines        5542     5542           
  Branches      939      939           
=======================================
  Hits         5190     5190           
  Misses        262      262           
  Partials       90       90           
Flag Coverage Δ
ubuntu-latest_3.10_mariadb-10.3 90.18% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.4 90.18% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.5 90.16% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.6 90.16% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.7 90.16% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.8 90.16% <ø> (ø)
ubuntu-latest_3.10_mysql-5.7 90.86% <ø> (ø)
ubuntu-latest_3.10_mysql-8.0 92.25% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.3 90.14% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.4 90.14% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.5 90.12% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.6 90.12% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.7 90.12% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.8 90.12% <ø> (ø)
ubuntu-latest_3.11-dev_mysql-5.7 90.83% <ø> (ø)
ubuntu-latest_3.11-dev_mysql-8.0 92.22% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.3 89.63% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.4 89.63% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.5 89.61% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.6 89.61% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.7 89.61% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.8 89.61% <ø> (ø)
ubuntu-latest_3.7_mysql-5.7 90.36% <ø> (ø)
ubuntu-latest_3.7_mysql-8.0 91.83% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.3 90.22% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.4 90.22% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.5 90.20% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.6 90.20% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.7 90.20% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.8 90.20% <ø> (ø)
ubuntu-latest_3.8_mysql-5.7 90.91% <ø> (ø)
ubuntu-latest_3.8_mysql-8.0 92.28% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.3 90.06% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.4 90.06% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.5 90.04% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.6 90.04% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.7 90.04% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.8 90.04% <ø> (ø)
ubuntu-latest_3.9_mysql-5.7 90.74% <ø> (ø)
ubuntu-latest_3.9_mysql-8.0 92.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiomysql/connection.py 84.26% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Nothing4You Nothing4You added this to the 0.2 milestone Oct 23, 2022
@Nothing4You
Copy link
Collaborator

good find, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants