Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about old version #104

Open
Arfey opened this issue Apr 19, 2019 · 10 comments
Open

Add warning about old version #104

Arfey opened this issue Apr 19, 2019 · 10 comments
Labels
easy Easy for first pull request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Arfey
Copy link
Member

Arfey commented Apr 19, 2019

If at run of create-air-app a new version is available, then output a warning. ⚠️

@Arfey Arfey added easy Easy for first pull request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 19, 2019
@Conor0Callaghan
Copy link

Were you thinking of a quick poll to an endpoint to check the version at startup @Arfey?

@Arfey
Copy link
Member Author

Arfey commented Oct 18, 2019

Yes. Of course, if user will not have a connection to the internet he also will can create a template without problems.

@Conor0Callaghan
Copy link

Yes. Of course, if user will not have a connection to the internet he also will can create a template without problems

Do you think the following logic would work?

  1. User starts application
  2. A function makes a simple HTTP poll to pypi for the package version, if connection fails, skip to step 4
  3. Compare package version with existing version and output warning if applicable
  4. Application starts

@Arfey
Copy link
Member Author

Arfey commented Oct 24, 2019

If Application in your logic is create-aio-app then yes.

@Conor0Callaghan
Copy link

Conor0Callaghan commented Oct 24, 2019

Updated version added here with some feedback from @Arfey and @MaxTyulin Conor0Callaghan@7ed8c7f

@Arfey
Copy link
Member Author

Arfey commented Mar 15, 2020

Hi, could u make a pull request with ur changes? 😀

@priyanshu20
Copy link

hi,
can i work on this if it is still relevant?

@Arfey
Copy link
Member Author

Arfey commented Apr 12, 2020

@ivernus please make a pull request with changes

@Arfey
Copy link
Member Author

Arfey commented Apr 12, 2020

@priyanshu20 i hope it's not relevant 😀
but if u wanna help, u can add handlers for 500 and 404 error

@Conor0Callaghan
Copy link

Sorry @Arfey i wasn't getting these notifications for some reason. Let me make the updates and send the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Easy for first pull request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants