Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add authorization #182

Open
3 tasks
Arfey opened this issue Apr 16, 2020 · 9 comments
Open
3 tasks

add authorization #182

Arfey opened this issue Apr 16, 2020 · 9 comments
Labels
help wanted Extra attention is needed

Comments

@Arfey
Copy link
Member

Arfey commented Apr 16, 2020

https://aiohttp-security.readthedocs.io/en/latest/

  • add login page
  • add view for login
  • add command for create a new user (make create_user)

user info - postgres
session data - redis

@Arfey Arfey added the help wanted Extra attention is needed label Apr 16, 2020
@everonegraham
Copy link
Contributor

Hey there Arfey, I will look into this over the weekend.

@Arfey
Copy link
Member Author

Arfey commented Aug 7, 2020

good luck 👍 if u'll have any questions feel free to ask. Also, i recommend u to do this task step by step and push small changes to review

@everonegraham
Copy link
Contributor

Hey there Arfey, had to be off for this for a good while. And starting to get back on it. Is the login page suppose to be the first page seen when running the app?

@Arfey
Copy link
Member Author

Arfey commented Sep 14, 2020

Hi. In my opinion, login page should not be as start page, because u can get index page without authz. Also when u run create-aio-app and after that make run u open login page but u don't have a user for login.

@everonegraham
Copy link
Contributor

True, I got the login is page ready. Just the page right now. No auth or postgres related data. Will be working on the auth side thru the week after work.

@amartya-dev
Copy link

@sanyen are you still working on this?

@everonegraham
Copy link
Contributor

Yes, on hold for personal reasons. Will be resuming this weekend.

@everonegraham
Copy link
Contributor

@amartya-dev feel free to take this over. Think I've bitten off a bit more than I can handle right now.

@amartya-dev
Copy link

Ok, I think my approach would be this:

  • Create a custom column for user password using SqlAlchemy's Varchar and func
  • Add a method to hash and match password strings possibly with a generated key and cryptography library
  • Add a method to create a user by setting the password using the create_user method I talked about in the previous point.
  • Add a login and register view
  • Add corresponding routes

Also, I would request the maintainers to include this in hacktoberfest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants