Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Adding pg_engine flag #27

Open
hzlmn opened this issue Oct 11, 2018 · 3 comments · May be fixed by #125
Open

Proposal: Adding pg_engine flag #27

hzlmn opened this issue Oct 11, 2018 · 3 comments · May be fixed by #125
Labels
enhancement New feature or request

Comments

@hzlmn
Copy link
Contributor

hzlmn commented Oct 11, 2018

Would be nice if tool provide ability to choose postgres engine (aiopg or asyncpg).
Possible command could looks like

create-aio-app project --pg_engine asyncpg

If you consider it as an option i could send pr.

@aio-libs-bot
Copy link

GitMate.io thinks possibly related issues are #24 (add wait script for redis), #1 (Add flake8 and travisci builds), #8 (Add test for the cookiecutter template), and #21 (Add Procfile for deploying to Heroku).

@aio-libs-bot aio-libs-bot added the enhancement New feature or request label Oct 11, 2018
@Arfey
Copy link
Member

Arfey commented Oct 14, 2018

I think it's good idea. I will wait for your pr 😀

@hzlmn
Copy link
Contributor Author

hzlmn commented Oct 16, 2018

There is current limitation in cookiecutter to add conditional options like if we check use_postgres only then we should choose postgres_engine option. So maybe it will be easier to combine this too options into one.

@aio-libs-bot aio-libs-bot mentioned this issue Dec 10, 2018
8 tasks
This was referenced Jan 11, 2019
@hzlmn hzlmn linked a pull request Apr 20, 2019 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants