Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to correct structure to cookiecutter format #56

Open
Arfey opened this issue Dec 24, 2018 · 8 comments
Open

need to correct structure to cookiecutter format #56

Arfey opened this issue Dec 24, 2018 · 8 comments
Labels
enhancement New feature or request

Comments

@Arfey
Copy link
Member

Arfey commented Dec 24, 2018

https://github.com/audreyr/cookiecutter#python.

The cookiecutter don't have template for aiohttp in repository, yet. So, i wanna add our template. For that repository need have special structure.

 hooks/
 {project.name}/
 cookiecutter.json

But for good install package all data need be localise inside same directory. I have two ways:

  • split this repository and use as sub-repository (one only for template and second for util)
  • do magic with setup.py(use cmdclass in setup and rewrite some methods)

@jettify @webknjaz what do u think?

@aio-libs-bot aio-libs-bot added the enhancement New feature or request label Dec 24, 2018
@aio-libs aio-libs deleted a comment from aio-libs-bot Dec 24, 2018
@webknjaz
Copy link
Member

What do you mean by saying localize?

@webknjaz
Copy link
Member

P.S. Don't bring setup-time code into the dist plz.

@Arfey
Copy link
Member Author

Arfey commented Dec 24, 2018

Current version:

setup.py
package/
    addition_data/

additional_data is existing (localized) in package dir.

For correct work cookiecutter we need have other structure:

setup.py
package/
addition_data/

So, if i move addition_data to the root after pip install the addition_data will be exist in site-packages not in site-packages/create-aio-app.

@webknjaz
Copy link
Member

Try symlink, then. Otherwise, follow my initial advice of having separate things separately.

@jettify
Copy link
Member

jettify commented Jan 12, 2019

I do not have experience with cookiecutter, but looks like other projects prefer separate repo.

@jettify
Copy link
Member

jettify commented Jan 12, 2019

If you guys think that we need separate repo I can handle repo logistics.

@webknjaz
Copy link
Member

webknjaz commented Jan 13, 2019

That's what I was pointing out since the very beginning. I still think it is a way to go.

@Arfey
Copy link
Member Author

Arfey commented Jan 13, 2019

good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants