Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

queryParameterValue must not be null #351

Open
masonHong opened this issue Jul 4, 2022 · 4 comments
Open

queryParameterValue must not be null #351

masonHong opened this issue Jul 4, 2022 · 4 comments

Comments

@masonHong
Copy link

masonHong commented Jul 4, 2022

I was using version 5.4.3, but when I upgraded to version 6.1.0, a crash occurred, so I checked it.

Fatal Exception: java.lang.NullPointerException: queryParameterValue must not be null
       at com.airbnb.deeplinkdispatch.BaseDeepLinkDelegate.queryAndPathParameters(BaseDeepLinkDelegate.java:530)
       at com.airbnb.deeplinkdispatch.BaseDeepLinkDelegate.createResult(BaseDeepLinkDelegate.java:286)
       at com.airbnb.deeplinkdispatch.BaseDeepLinkDelegate.dispatchFrom(BaseDeepLinkDelegate.java:70)
       at com.airbnb.deeplinkdispatch.BaseDeepLinkDelegate.dispatchFrom$default(BaseDeepLinkDelegate.java:64)

When I reproduced it, a crash occurs when Uri of the pattern below is used.

  • myScheme://host/path1/path2?query1&query2
  • myScheme://host/path1/path2?

Uri have a query with no value or with ? but no query.

Can you fix the problem?

EricKuck added a commit to EricKuck/DeepLinkDispatch that referenced this issue Jul 19, 2022
rossbacher pushed a commit that referenced this issue Jul 20, 2022
* Fix NPE in issue #351

* Added test to prevent regressions
@jackcsk
Copy link

jackcsk commented Dec 15, 2022

@EricKuck are we expecting a new release including that fix soon?

@EricKuck
Copy link
Contributor

I am not a maintainer on this project. Can't say if/when a new release is coming out.

@jackcsk
Copy link

jackcsk commented Dec 15, 2022

My bad, sorry Eric.

@jackcsk
Copy link

jackcsk commented Dec 15, 2022

@rossbacher : not sure if you are the right person to address to, or please help me to refer to the right person
Wanna know when this fix will be included in the new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants