Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showkase.getBrowserIntent() not generated when there are no showkase previews #334

Open
matejdro opened this issue Jun 29, 2023 · 1 comment

Comments

@matejdro
Copy link

When there are no previews in the app, Showkase.getBrowserIntent() will not get generated even if there is a @ShowkaseRoot present.

Ideally, this Intent should still be generated, but be empty of course.

Our use case for this is that we want to include Showkase into a template project that we create other projects from (and this project includes full Showkase setup). However, because of this issue, template project will not build, because there are no Composables in it.

@matejdro matejdro changed the title Showkase.getBrowserIntent() not generated when there are no showkase previee Showkase.getBrowserIntent() not generated when there are no showkase previews Jun 29, 2023
@vinaygaba
Copy link
Collaborator

Yeah I think this will help make the library be more deterministic. Especially the APIs that are generated at the top level should probably be generated to make sure there are no build failures when there are no composables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants