Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix in readme #35

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Minor fix in readme #35

merged 1 commit into from
Jun 7, 2018

Conversation

auridevil
Copy link
Contributor

every time a user copy-paste the npm instruction get also the $. now is clear.

Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please rebase this on the command line down to one commit?

@@ -7,7 +7,7 @@ Babel plugin to transpile `import()` to a deferred `require()`, for node. Matche
## Installation

```sh
$ npm install babel-plugin-dynamic-import-node --save-dev
npm install babel-plugin-dynamic-import-node --save-dev
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the $ is part of the shell prompt; but sure, this is fine.

@ljharb ljharb merged commit 78bfcf6 into airbnb:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants