Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking] always return a module namespace object #52

Merged
merged 1 commit into from
Jun 26, 2018
Merged

[Breaking] always return a module namespace object #52

merged 1 commit into from
Jun 26, 2018

Conversation

ljharb
Copy link
Collaborator

@ljharb ljharb commented Jun 23, 2018

Fixes #47.

This uses the interopRequireWildcard helper to obtain the module namespace object.

@ljharb ljharb requested review from lencioni and kesne June 23, 2018 07:06
@kesne
Copy link
Collaborator

kesne commented Jun 26, 2018

LGTM

@ljharb ljharb merged commit cae269d into master Jun 26, 2018
@ljharb ljharb deleted the spec branch June 26, 2018 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lencioni lencioni lencioni approved these changes

@kesne kesne Awaiting requested review from kesne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ljharb @kesne @lencioni