Calling props() after a state change should be updated to find()
#1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has come about from this issue: #1299
|
As far as I understand it, this is a side effect of https://github.com/airbnb/enzyme/blob/master/docs/guides/migration-from-2-to-3.md#element-referential-identity-is-no-longer-preserved, so maybe it makes sense to put this as a sub-head under that? |
ljharb
force-pushed
the
master
branch
4 times, most recently
from
40cc703
to
0a17404
Compare
|
@peter-mouland any interest in updating this PR? |
|
hey, yeah - can do, do you have any stats on how many people look at the migrate docs now? |
|
I'm afraid github doesn't offer any of those stats :-/ but i did get a bug or three filed about its content in the last 6 months, so it's not nobody! |
|
cool - consider it updated. I've also updated the example to make it more consistent / readable (it was a while ago i wrote this up, old code never looks good 🤦♂️ !!) |
ljharb
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has come about from this issue: #1299
If I have misunderstood anything please let me know.
Thanks