Invoke() api #1856
Merged
Invoke() api #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't had time to work on my PR, so thanks for this! |
|
@woutervanvliet Thank you for your reviews! I've fixed them. |
ljharb
requested changes
Nov 12, 2018
|
@koba04 ping, still interested in this? |
|
@ljharb OK, I'll work on it again! |
|
I've recreated the branch from |
koba04
force-pushed
the
invoke-api
branch
2 times, most recently
from
1eecdaf
to
5e28ce4
Compare
|
@ljharb I’ve addressed you comment and rebased this! |
ljharb
requested changes
Mar 13, 2019
| } | ||
| return (...args) => { | ||
| const response = handler.apply(this, args); | ||
| this[ROOT].update(); |
There was a problem hiding this comment.
@ljharb
The purpose is to reflect the updates into the ShallowWrapper instance if the handler calls setState.
It's the same as what simulate() is doing.
https://github.com/airbnb/enzyme/blob/master/packages/enzyme/src/ShallowWrapper.js#L999
But I've covered the most case by this PR so this might be unnecessary.
| } | ||
| return (...args) => { | ||
| const response = handler.apply(this, args); | ||
| this[ROOT].update(); |
This reverts commit eb14926cbc5de867745ca7c892bda533ddff043b.
ljharb
approved these changes
Apr 6, 2019
|
I'm not sure what's going on with coverage there; I'm going to merge anyways. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to pick up from #945
If @milesj is still working on #945, feel free to close this!