Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] html: shallow renders full tree #1912

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Conversation

zbycz
Copy link
Contributor

@zbycz zbycz commented Nov 21, 2018

I was very confused, why shallow().html() returns the whole HTML tree. This is kind of unxepected, so this PR can help others undestand.

I found that its expected behavior here: #388 (comment)

btw, how does it really work? Does it call the same render method for both mount() and shallow()? Possibly even for render()? Thanks!

@ljharb
Copy link
Member

ljharb commented Nov 21, 2018

.html() calls into render.

What is probably wanted most of the time is .debug().

@zbycz
Copy link
Contributor Author

zbycz commented Nov 22, 2018

@ljharb Thanks for the clarification! I accepted your suggestion and added a sentence about internal workings and hint for debug.

I hope several commits are fine - github can squash em, right?

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit 11d7015 into enzymejs:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants