Update: Adds recursive check for isEmptyRender #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [New] `utils`: add `recursiveEmptyRender` and `isEmptyValue` Fixes enzymejs#1866.
ljharb
reviewed
Dec 4, 2018
packages/enzyme/src/Utils.js
Outdated
| const renderedKey = 'rendered'; | ||
|
|
||
| function dive(renderedNodes) { | ||
| const isList = renderedNodes && renderedNodes.length > 0 && Array.isArray(renderedNodes); |
There was a problem hiding this comment.
= Array.isArray(renderedNodes) && renderedNodes.length > 0?
packages/enzyme/src/Utils.js
Outdated
| return isEmptyRender; | ||
| } | ||
|
|
||
| dive(nodes); |
There was a problem hiding this comment.
could this not be return dive(nodes)?
There was a problem hiding this comment.
So initially I did have that. And then in my utils test cases, I was getting inconsistent return values. I will change back, bc this is something I prefer and research why.
ljharb
reviewed
Dec 12, 2018
sstern6
force-pushed
the
issue-1866
branch
2 times, most recently
from
9d57bf4
to
169809e
Compare
ljharb
reviewed
Dec 13, 2018
sstern6
force-pushed
the
issue-1866
branch
3 times, most recently
from
9e85957
to
7aea80b
Compare
ljharb
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1866