Find html elements by class #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Dec 10, 2018
ljharb
requested changes
Dec 12, 2018
ljharb
reviewed
Dec 13, 2018
ljharb
reviewed
Dec 18, 2018
ljharb
requested changes
Dec 20, 2018
|
I've rebased this; I think some things need to be rethought. The current map is needed for tests - of tag names to element constructors - but a similar map is needed in Before making changed, please reset your local branch to match the rebased commit I've pushed up. |
ljharb
requested changes
Jan 11, 2019
ljharb
approved these changes
Jan 27, 2019
There was a problem hiding this comment.
I ended up publishing https://npmjs.com/html-element-map and updated this PR to use it; I'll merge after tests pass.
|
(linking to aweary/rst-selector-parser#15 as well) |
falsefalse
reviewed
Mar 27, 2019
| * @param {RSTNode} root | ||
| */ | ||
| export function reduceTreeBySelector(selector, root) { | ||
| if (typeof selector !== 'string') { | ||
| const elements = elementsByConstructor(selector); |
There was a problem hiding this comment.
This pops "Update your Java installation" in IE11 😢
ljharb/html-element-map#3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1929.
@ljharb This is the the test case that I wrote. Could you check and see if it's the right idea before I continue writing it for all the other elements?