Fix .exists not accepting any EnzymeSelector #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btimo
force-pushed
the
fix/exists-selector-component
branch
from
a3568c0
to
6d30358
Compare
`.exists`, since [enzymejs#1695](enzymejs#1695), accepts an optional selector. Unfortunately, this optional parameter was limited to the `string` type whereas the documentation inform us it can be any valid [EnzymeSelector](https://airbnb.io/enzyme/docs/api/selector.html). This commit fixes this limitation by accepting any type for the parameter and using `.find()` internal functions to throw any necessary `TypeError`.
btimo
force-pushed
the
fix/exists-selector-component
branch
from
6d30358
to
b03e12e
Compare
ljharb
reviewed
Dec 10, 2018
| @@ -1073,14 +1073,11 @@ class ReactWrapper { | |||
| * Returns true if the current wrapper has nodes. False otherwise. | |||
| * If called with a selector it returns `.find(selector).exists()` instead. | |||
| * | |||
| * @param {String|Function} selector (optional) | |||
| * @param {String|Function|Object} selector (optional) | |||
There was a problem hiding this comment.
The signature for find is * @param {String|Function} selector - should that be changed, or should this one stay the same?
There was a problem hiding this comment.
Not sure about what you're asking:
- I changed
findsignature to* @param {String|Function|Object} selector - Internally,
findwill use theselectorwith functions that accepts{String|Function|Object} EnzymeSelectorandfinddocumentation show that you can call it with anObject:
There was a problem hiding this comment.
I mean that the jsdoc comment for find in both ShallowWrapper and ReactWrapper say "string or function" - so it seems like it should be "string or function or object" as well
There was a problem hiding this comment.
ljharb
approved these changes
Dec 11, 2018
|
Thanks for filing this! It's great to ensure consistency :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.exists, since #1695, accepts an optional selector.Unfortunately, this optional parameter was limited to the
stringtype whereas the documentation inform us it can be any valid EnzymeSelector.This commit fixes this limitation by accepting any type for the parameter and using
.find()internal functions to throw any necessaryTypeError.