[New]: selectors: support universal selector
#1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Dec 16, 2018
chenesan
force-pushed
the
support_universal_selector
branch
from
049b165
to
9426503
Compare
|
@ljharb added 4 more tests like |
eps1lon
reviewed
Dec 17, 2018
|
Does this only select DOM nodes or also components (class or function etc). |
|
Currently it's only for DOM nodes. Just like other string css selectors. |
chenesan
force-pushed
the
support_universal_selector
branch
from
9426503
to
67e0949
Compare
|
Could we add a test to ensure that this is not returning other components? I'm asking because I currently use a helper getter to find the outermost DOM node in a subtree with findWhere and this could potentially replace that. |
|
@chenesan all the selectors in enzyme select on all kinds of nodes, not just DOM nodes. |
|
@eps1lon you may want |
chenesan
force-pushed
the
support_universal_selector
branch
from
67e0949
to
eb16f50
Compare
|
@ljharb Sorry for misleading! I just added one test to show that universal selector also select component node. |
This comment has been minimized.
This comment has been minimized.
ljharb
changed the title
selectors: support universal selectorselectors: support universal selector
This comment has been minimized.
This comment has been minimized.
chenesan
force-pushed
the
support_universal_selector
branch
3 times, most recently
from
eee9542
to
11dc5ec
Compare
ljharb
approved these changes
Jan 29, 2019
ljharb
force-pushed
the
support_universal_selector
branch
from
11dc5ec
to
7bd0bdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1158 .
Note that rst-selector-parser has universal selector support now so we only need to change selectors code in enzyme.