[Tests] [Refactor] move and share shallow/mount tests to individual files for each method
#2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al files for each method: - `Symbol.iterator` - `at` - `childAt` - `children` - `closest` - `contains` - `containsAllMatchingElements` - `containsAnyMatchingElements` - `containsMatchingElement` - `debug` - `equals` - `every` - `everyWhere` - `exists` - `filter` - `filterWhere` - `find` - `findWhere` - `first` - `flatMap` - `forEach` - `get` - `getElement` - `getElements` - `getNode` - `getNodes` - `hasClass` - `hostNodes` - `html` - `instance` - `is` - `isEmpty` - `isEmptyRender` - `key` - `last` - `map` - `matchesElement` - `name` - `not` - `parent` - `parents` - `prop` - `props` - `reduce` - `reduceRight` - `render` - `renderProp` - `root` - `setContext` - `setProps` - `setState` - `simulate` - `simulateError` - `single` - `slice` - `some` - `someWhere` - `state` - `tap` - `text` - `wrap` - `unmount`
ljharb
force-pushed
the
test_refactor
branch
2 times, most recently
from
0c8a9d6
to
edc1caf
Compare
ljharb
force-pushed
the
test_refactor
branch
3 times, most recently
from
bd370f6
to
e17eb34
Compare
madicap
approved these changes
Mar 28, 2019
ljharb
force-pushed
the
test_refactor
branch
3 times, most recently
from
60c4dd9
to
6f60a00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbol.iteratoratchildAtchildrenclosestcontainscontainsAllMatchingElementscontainsAnyMatchingElementscontainsMatchingElementdebugequalseveryeveryWhereexistsfilterfilterWherefindfindWherefirstflatMapforEachgetgetElementgetElementsgetNodegetNodeshasClasshostNodeshtmlinstanceisisEmptyisEmptyRenderkeylastmapmatchesElementnamenotparentparentsproppropsreducereduceRightrenderrenderProprootsetContextsetPropssetStatesimulatesimulateErrorsingleslicesomesomeWherestatetaptextwrapunmountAlso updated the contribution guide to reflect this.
Oddly, though - I would expect coverage to either remain the same, or to go up, since this branch ends up starting to run a number of previously shallow-only or mount-only on the other wrapper API - but it seems like it's gone down.