Wrap .Invoke() with act to make trigger rerender by handler less error prone
#2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Jun 10, 2019
| @@ -495,6 +495,7 @@ class ReactSixteenAdapter extends EnzymeAdapter { | |||
| }), | |||
| }; | |||
| }, | |||
| act: wrapAct, | |||
There was a problem hiding this comment.
this is semver-minor in the adapter
chenesan
force-pushed
the
invoke-with-act
branch
from
18dad79
to
b5281db
Compare
|
@ljharb Just address the review and rebase on master to resolve the conflict :) |
chenesan
force-pushed
the
invoke-with-act
branch
from
acfcf0b
to
b5281db
Compare
ljharb
added
API: mount
package: react adapter: 16
semver: minor
ljharb
approved these changes
Jun 11, 2019
ljharb
force-pushed
the
invoke-with-act
branch
2 times, most recently
from
9761bf2
to
d2bb655
Compare
ljharb
added a commit
that referenced
this pull request
Oct 9, 2019
- [new] add Profiler support for react v16.9+ (#2233) - [new] add `wrapInvoke` to adapter (#2158) - [refactor] use `enzyme-shallow-equal` - [dev deps] update `eslint`, `eslint-plugin-react`, `eslint-config-airbnb`, `eslint-plugin-import`, `eslint-plugin-jsx-a11y`, `eslint-plugin-react`, `safe-publish-latest` - [meta] Update airbnb.io URLs to use https (#2222)
This was referenced Oct 17, 2019
13 tasks
ljharb
added a commit
that referenced
this pull request
Dec 20, 2019
New Stuff - `render`: handle Fiber strings and numbers (#2221) Fixes - `shallow`: Share child context logic between `shallow` and `dive` (#2296) - `mount`: `children`: include text nodes ($2269) - `mount`: `invoke`: use adapter’s `wrapInvoke` if present (#2158) Docs - `mount`/`shallow`: `closest`/`parent`: Add missing arguments description (#2264) - `mount`/`shallow`: fix pluralization of “exist” (#2262) - `shallow`/`mount`: `simulate`: added functional component example to simulate doc (#2248) - `mount`: `debug`: add missing verbose option flag (#2184) - `mount`/`shallow`: `update`: fix semantics description (#2194) - add missing backticks to linked method names (#2170) - `invoke`: Add missing backticks to end of codeblock (#2160) - `invoke`: Fix typo (#2167) - Explicit React CSS selector syntax description (#2178) Meta Stuff - [meta] add `funding` field - [meta] Update airbnb.io URLs to use https (#2222) - [deps] update `is-boolean-object`, `is-callable`, `is-number-object`, `is-string`, `enzyme-shallow-equal`, `array.prototype.flat`, `function.prototype.name`, `html-element-map`, `is-r egex`, `object-inspect`, `object-is`, `object.entries`, `object.vales`, `raf`, `string.prototype.trim` - [dev deps] update `eslint`, `eslint-plugin-import`, `eslint-plugin-markdown`, `eslint-plugin-react`, `safe-publish-latest`, `eslint-config-airbnb`, `rimraf`, `safe-publish-latest`, `k arma-firefox-launcher`, `babel-preset-airbnb`, `glob-gitignore`, `semver`, `eslint-plugin-jsx-a11y`
This was referenced Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expose
actcall out ofenzyme-adapter-react-16and make theinvokeapi call handler withact. This will make the added test case passed without explicitly callact(). Before this change, we have to callact()outside of theonClickhandler manually, which is easy to forget to do that.Also update the doc of
invoketo encourage people to trigger handler with it (so we don't need to explictly callact()andupdate()).