Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: airbnb/javascript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: eslint-config-airbnb-base-v13.1.0
Choose a base ref
...
head repository: airbnb/javascript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: eslint-config-airbnb-base-v13.2.0
Choose a head ref
35 contributors

Commits on Jan 19, 2017

  1. [guide] update to a better Chinese translation

    @ljharb
    侯林江 authored and ljharb committed Jan 19, 2017
    Copy the full SHA
    02b4eea View commit details

Commits on Aug 13, 2018

  1. [eslint config] [deps] update eslint-config-airbnb-base, `eslint-pl… 

    …ugin-react`
    @ljharb
    ljharb committed Aug 13, 2018
    Copy the full SHA
    152b914 View commit details

  2. [eslint config] [patch] re-enabling jsx-one-expression-per-line all… 

    …owing single children, ignore DOM components on `jsx-no-bind`; re-enable `restructuring-assignment`

Reverts b6a268f
    @ljharb
    ljharb committed Aug 13, 2018
    Copy the full SHA
    9a52676 View commit details

  3. [eslint config] v17.1.0

    @ljharb
    ljharb committed Aug 13, 2018
    Copy the full SHA
    685f37b View commit details

Commits on Aug 26, 2018

  1. Fix outdated link to Airbnb's Neutrino preset

    @kevinweber @ljharb
    kevinweber authored and ljharb committed Aug 26, 2018
    Copy the full SHA
    fcfd378 View commit details

  2. [guide] Clarify wording

    @kevinweber @ljharb
    kevinweber authored and ljharb committed Aug 26, 2018
    Copy the full SHA
    ffe4fe9 View commit details

Commits on Aug 27, 2018

  1. List bad example first to be consistent

    @kevinweber
    kevinweber committed Aug 27, 2018
    Copy the full SHA
    ced1cb3 View commit details

  2. Merge pull request #1898 from kevinweber/react/props--unnecessary-props 

    List bad example first to be consistent
    @ljharb
    ljharb authored Aug 27, 2018
    Copy the full SHA
    d774b89 View commit details

  3. [guide] Consistently use curly quotes instead of straight quotes in p… 

    …rose
    @kevinweber @ljharb
    kevinweber authored and ljharb committed Aug 27, 2018
    Copy the full SHA
    5443d03 View commit details

  4. [guide] [react] Explain use of ID over key right on page

    @kevinweber @ljharb
    kevinweber authored and ljharb committed Aug 27, 2018
    Copy the full SHA
    48448a8 View commit details

Commits on Aug 31, 2018

  1. Add Pier1 to the organization list

    Robert Alvarez committed Aug 31, 2018
    Copy the full SHA
    b8b2a0b View commit details

Commits on Sep 1, 2018

  1. [eslint config] [base] [minor] Enforce dangling underscores in method… 

    … names
    @JBallin @ljharb
    JBallin authored and ljharb committed Sep 1, 2018
    Copy the full SHA
    17e0454 View commit details

Commits on Sep 2, 2018

  1. Update .markdownlint.json 

    Fixed typos and grammar
    @darksun27 @ljharb
    darksun27 authored and ljharb committed Sep 2, 2018
    Copy the full SHA
    e7ffd44 View commit details

Commits on Sep 12, 2018

  1. ✏️ fix docs for whitespace config

    @a-tokyo
    a-tokyo committed Sep 12, 2018
    Copy the full SHA
    32a7bf4 View commit details

Commits on Sep 14, 2018

  1. Examples more consistent with the guidline 

    comparison operator <= shows better the confusion when using arrow function, than just operator <
    @ernestodebesto @ljharb
    ernestodebesto authored and ljharb committed Sep 14, 2018
    Copy the full SHA
    69e3437 View commit details

Commits on Oct 2, 2018

  1. Updated wording of variable--one-const rule

    @parulgupta26
    parulgupta26 committed Oct 2, 2018
    Copy the full SHA
    9af5ee8 View commit details

Commits on Oct 3, 2018

  1. [doc] add eslint rule reference for no-prototype-builtins

    @1pete
    1pete authored Oct 3, 2018
    Copy the full SHA
    924dfb2 View commit details

Commits on Oct 4, 2018

  1. [doc] add eslint rule references in react guide 

    * react/jsx-filename-extension
* react/no-array-index-key
    @1pete
    1pete authored Oct 4, 2018
    Copy the full SHA
    24da5bb View commit details

Commits on Oct 16, 2018

  1. Add UrbanSim to organizations list

    @martjanz
    martjanz authored Oct 16, 2018
    Copy the full SHA
    03a0734 View commit details

Commits on Oct 30, 2018

  1. [19.16] changed Enforce to avoid 

    Good practice is to avoid spaces between functions and their invocations. But by mistake (I think so) you used the word Enforce instead of Avoid
    @theBstar
    theBstar authored Oct 30, 2018
    Copy the full SHA
    41a13e8 View commit details

Commits on Nov 13, 2018

  1. [editorial] Improve conciseness of README.md

    @KY3LxD @ljharb
    KY3LxD authored and ljharb committed Nov 13, 2018
    Copy the full SHA
    74deb81 View commit details

Commits on Nov 20, 2018

  1. [eslint config] [base] [deps] Switch to confusing-browser-globals 

    The `eslint-restricted-globals` package author created an equivalent
package `confusing-browser-globals` that now resides within the
create-react-app monorepo. In sidoshi/eslint-restricted-globals#2
@sidoshi suggested that we change eslint-config-airbnb-base to depend
on the CRA package instead, in an effort to consolidate the two.

Currently the two global lists are identical, so this does not change
the generated eslint config:
https://unpkg.com/eslint-restricted-globals@0.2.0/index.js
https://unpkg.com/confusing-browser-globals@1.0.5/index.js
    @edmorley @ljharb
    edmorley authored and ljharb committed Nov 20, 2018
    Copy the full SHA
    21b65e9 View commit details

Commits on Nov 21, 2018

  1. [17.2] Added second anchor #1960 

    See requested changes here: #1960 (review)
    @NullDev @ljharb
    NullDev authored and ljharb committed Nov 21, 2018
    Copy the full SHA
    0d6d854 View commit details

  2. Added NullDev 

    because why not
    @NullDev @ljharb
    NullDev authored and ljharb committed Nov 21, 2018
    Copy the full SHA
    6ece1f5 View commit details

Commits on Nov 27, 2018

  1. :) conflicting with rule 8.2 :D

    @michaelKaefer
    michaelKaefer authored Nov 27, 2018
    Copy the full SHA
    064e3bf View commit details

Commits on Dec 18, 2018

  1. capitalize means first letter uppercase, the rest lowercase 

    The examples and the reasoning indicates the author of the rule meant uppercase instead of capitalization. According to Wikipedia, capitalization is "writing a word with its first letter as a capital letter (uppercase letter) and the remaining letters in lower case", while the rule apparently tries to prevent exactly that.
    @honzajavorek
    honzajavorek authored Dec 18, 2018
    Copy the full SHA
    5d25a2e View commit details

Commits on Dec 19, 2018

  1. Add Terra to README list

    @emilyrohrbough
    emilyrohrbough authored Dec 19, 2018
    Copy the full SHA
    80920a0 View commit details

Commits on Dec 28, 2018

  1. [eslint config] [base] [fix] disable no-var in legacy entry point 

    Fixes #1935.
    @ljharb
    ljharb committed Dec 28, 2018
    Copy the full SHA
    218c4fe View commit details

  2. [meta] add disabled no-useless-catch config

    @ljharb
    ljharb committed Dec 28, 2018
    Copy the full SHA
    387755e View commit details

  3. [Dev Deps] update markdownlint-cli

    @ljharb
    ljharb committed Dec 28, 2018
    Copy the full SHA
    070e620 View commit details

Commits on Jan 7, 2019

  1. [guide] [react] add note about forbid-prop-types rule

    @ljharb
    Rahil Vora authored and ljharb committed Jan 7, 2019
    Copy the full SHA
    95286eb View commit details

Commits on Jan 13, 2019

  1. Vietnamese translation

    @dangkyokhoang
    dangkyokhoang committed Jan 13, 2019
    Copy the full SHA
    955f4e9 View commit details

Commits on Jan 21, 2019

  1. [eslint config] [base] [patch] Allow use of `__REDUX_DEVTOOLS_EXTENSI… 

    …ON_COMPOSE__`

This style guide disallows the use of underscores in properties. However, the
Redux browser extension requires the use of a variable named
`__REDUX_DEVTOOLS_EXTENSION_COMPOSE__`. Since Redux is so popular with React,
it makes sense to allow this.
    @remcohaszing @ljharb
    remcohaszing authored and ljharb committed Jan 21, 2019
    Copy the full SHA
    b6c56cb View commit details

Commits on Jan 26, 2019

  1. [editorial] [react] fix typo

    @telmen @ljharb
    telmen authored and ljharb committed Jan 26, 2019
    Copy the full SHA
    1439ebe View commit details

  2. [eslint config] [patch] extend no-underscore-dangle to allow for re… 

    …dux dev tools in the main config instead
    @ljharb
    ljharb committed Jan 26, 2019
    Copy the full SHA
    25f11fb View commit details

Commits on Jan 27, 2019

  1. [eslint config] [*] [deps] update object.entries, `eslint-plugin-im… 

    …port`, `eslint-plugin-jsx-a11y`, `eslint-plugin-react`
    @ljharb
    ljharb committed Jan 27, 2019
    Copy the full SHA
    d8256fc View commit details

Commits on Jan 28, 2019

  1. Merge pull request #1996 from remcohaszing/redux-devtools-extension-c… 

    …ompose

[eslint config] [base] [patch] Allow use of `__REDUX_DEVTOOLS_EXTENSION_COMPOSE__`
    @ljharb
    ljharb authored Jan 28, 2019
    Copy the full SHA
    d78af39 View commit details

Commits on Jan 30, 2019

  1. [eslint config] [base] [patch] no-extraneous-dependencies: Add jest… 

    ….setup.js to devDeps
    @tclindner @ljharb
    tclindner authored and ljharb committed Jan 30, 2019
    Copy the full SHA
    96f95fa View commit details

Commits on Feb 5, 2019

  1. Merge branch 'master' into translation-proposal

    @sharmilajesupaul
    sharmilajesupaul authored Feb 5, 2019
    Copy the full SHA
    ebe9682 View commit details

Commits on Feb 6, 2019

  1. [guide] make "good" example match "bad" example more closely

    @ziishaned @ljharb
    ziishaned authored and ljharb committed Feb 6, 2019
    Copy the full SHA
    6ef45d4 View commit details

Commits on Feb 7, 2019

  1. [eslint config] [*] [readme] Improve eslint config setup instructions… 

    … for yarn
    @ljharb
    Pier-Luc Brault authored and ljharb committed Feb 7, 2019
    Copy the full SHA
    4f15da6 View commit details

Commits on Feb 13, 2019

  1. [guide] fix example 4.7 for arrays method callbacks

    @mapb @ljharb
    mapb authored and ljharb committed Feb 13, 2019
    Copy the full SHA
    495a62a View commit details

Commits on Feb 14, 2019

  1. [eslint config] [react] [patch] Turn off react/no-multi-comp 

    Splitting up a component into multiple components can be useful for many reasons, including making important performance optimizations.

This lint rule discourages splitting up components because it forces you to: create a new file, copy over all the relevant imports, move over any local functions/values (or move them into yet another shared module), export the component (which makes your split off component now a public export), and re-import it into the new module.

Having multiple components per file shouldn't be much different from having multiple functions per file. And you shouldn't be forced to make a component a public export if it's really just an internal implementation detail of another component.

There's an argument to be made about _exporting_ multiple components, but mostly just in the context of React.lazy because it can only import default exports and you don't want something else in that file being statically imported (because that will prevent it from being code-split).
    @jamiebuilds @ljharb
    jamiebuilds authored and ljharb committed Feb 14, 2019
    Copy the full SHA
    8694a87 View commit details

Commits on Feb 17, 2019

  1. [eslint config] [*] [deps] update eslint-plugin-import, `eslint-plu… 

    …gin-jsx-a11y`, `tape`
    @ljharb
    ljharb committed Feb 17, 2019
    Copy the full SHA
    834d717 View commit details

  2. [eslint config] add disabled jsx-fragments rule

    @ljharb
    ljharb committed Feb 17, 2019
    Copy the full SHA
    a71c2d1 View commit details

  3. [Tests] on node v11

    @ljharb
    ljharb committed Feb 17, 2019
    Copy the full SHA
    da0cf08 View commit details

Commits on Feb 24, 2019

  1. [guide] [react] add more context about arrow functions, as props and … 

    …in class fields
    @Ensive @ljharb
    Ensive authored and ljharb committed Feb 24, 2019
    Copy the full SHA
    be07f7a View commit details

Commits on Feb 27, 2019

  1. [guide] Add a 19.9 bullet in a Whitespace section 

    - with explanations about preventing two blank lines from  appearing consecutively in JavaScript code
    @Ensive @ljharb
    Ensive authored and ljharb committed Feb 27, 2019
    Copy the full SHA
    60b96d3 View commit details

Commits on Mar 4, 2019

  1. [eslint config] [base] [meta] add disabled `prefer-named-capture-grou… 

    …p` rule
    @ljharb
    ljharb committed Mar 4, 2019
    Copy the full SHA
    b85baea View commit details

Commits on Apr 10, 2019

  1. [guide] remove extra blank line

    @bertho-zero @ljharb
    bertho-zero authored and ljharb committed Apr 10, 2019
    Copy the full SHA
    4474666 View commit details
1 change: 1 addition & 0 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
language: node_js
node_js:
- "11"
- "10"
- "9"
- "8"
Loading