Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax react-hooks plugin peer dep? #2195

Closed
billyjanitsch opened this issue Mar 14, 2020 · 1 comment
Closed

relax react-hooks plugin peer dep? #2195

billyjanitsch opened this issue Mar 14, 2020 · 1 comment

Comments

@billyjanitsch
Copy link
Contributor

billyjanitsch commented Mar 14, 2020

Hi @ljharb,

It looks like you published eslint-config-airbnb@18.1.0 to npm yesterday, but didn't push some associated commits to the GitHub repo. In particular, package.json still lists its version as 18.0.1.

The other change that I noticed is that master's peer dependency on eslint-plugin-react-hooks is listed as ^2.0.0 || ^1.7.0, but the published version's dependency is on ^2.5.0 || ^1.7.0.

I was going to ask if this could be relaxed back to ^2.0.0 || ^1.7.0. The 2.5.0 release includes a somewhat controversial change. Basically, one of its rules now uses ESLint's new "suggestions" feature instead of the auto-fix feature. Most IDE extensions haven't caught up to this feature, and there's currently no way to apply suggestions via the ESLint CLI, so I imagine many users will want to pin this dependency at 2.4.0 until they are able to properly use 2.5.0. This is not possible with the current peer dep range.

(Happy to make a new issue for this, or rename this issue, once those commits are on GH!)

Thanks, as always, for your work maintaining these configs. 😊

@ljharb
Copy link
Collaborator

ljharb commented Mar 14, 2020

Yes, thanks, I’m aware :-) the tags aren’t there, it’s just not pushed to master yet.

From reading the description in the PR, yes, I’ll relax it back to v2.3 in a patch.

@ljharb ljharb changed the title New version published to npm without accompanying repo commits relax react-hooks plugin peer dep? Mar 15, 2020
@ljharb ljharb closed this as completed in f075a0d Mar 17, 2020
rchrdw pushed a commit to rchrdw/javascript that referenced this issue Feb 18, 2021
eugene2candy pushed a commit to eugene2candy/javascript that referenced this issue Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants