-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NullPointerException crash in LottieComposition.getLayers() #1958
Labels
Milestone
Comments
gpeal
pushed a commit
that referenced
this issue
Dec 13, 2021
This PR addresses the issue #1958 , although the crash is pretty hard to reproducible, the enhancement will definitely make it more robust. The issue was in com.airbnb.lottie.LottieDrawable#buildCompositionLayer method. The related code is: private void buildCompositionLayer() { compositionLayer = new CompositionLayer( this, LayerParser.parse(composition), composition.getLayers(), composition); if (outlineMasksAndMattes) { compositionLayer.setOutlineMasksAndMattes(true); } } The crash exception stack prints: Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'java.util.List com.airbnb.lottie.LottieComposition.getLayers()' on a null object reference at com.airbnb.lottie.LottieDrawable.buildCompositionLayer(LottieDrawable.java:298) ... As we can see, the exception occurs at composition.getLayers(), but before executing this statement, the LayerParser.parse(composition) statement also refers to the composition object, which was fine, but after that this object had been set to null, thus caused NPE. I think this issue is very similar to the issues resolved in PR #1917
Hello hello I understand the digital breakdown of the data to form receipts
codes now what they call promo codes and other transactions are receipts of
transactioning a cell data deletion and everything that the membrane pulls
up and you guys you need codes using numbers YZ 8 through zero g and H2 x
so I'm just saying the codes that now or not much of a key as a skeleton
key or a key to the state or key to other businesses these are basically
promo codes and Kohl's to you guys company of sales put outs inputs and
receipts therefore I would not indulge still transact structure makeup draw
anything from you guys state of data to so what call a key to spend on Nerf
years communication etc I would rather have my money a trust funding the
bank with a bank account of my own instead of to be penalized and you guys
report me back to the people that I invest with as Steph robbery class at a
felony FBI approved and it's insurance another choice that adds up to five
days to a year Day to a year etc thank you
…On Mon, Dec 13, 2021, 4:47 PM Gabriel Peal ***@***.***> wrote:
Closed #1958 <#1958>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1958 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWVHDZYS23AEJ3VSV46UC73UQZZYRANCNFSM5JYSA4BQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Race condition caused NPE.
See the exception stack below:
This is a race condition issue so not always reproducible.
I was using version 3.4.1, but I checked the code in master branch, the key part to this issue keeps the same between version 3.4.1 and the latest version 4.2.2.
Steps To Reproduce
Race condition issue, there is no fix steps to reproduce.
See the issue analysis in PR #1959 .
The text was updated successfully, but these errors were encountered: