Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning "react-dates > react-with-styles@3.2.1" has unmet peer dependency "react-with-direction@^1.1.0". #1348

Closed
joanjoantan opened this issue Sep 7, 2018 · 3 comments
Assignees

Comments

@joanjoantan
Copy link

With react (^16.2.0):

package.json

"react": "^16.2.0",
    "react-accessible-accordion": "^2.4.4",
    "react-collapsible-component": "^1.1.0",
    "react-cookie": "^2.1.2",
    "react-dates": "^16.3.6",
    "react-debounce-input": "^3.2.0",
    "react-dev-utils": "lendingworks/react-dev-utils",
    "react-dom": "^16.2.0",
    "react-idle-timer": "^4.0.8",
    "react-loading-placeholder": "^1.0.6",
    "react-moment": "^0.7.0",
    "react-moment-proptypes": "^1.5.0",
    "react-paginate": "^5.2.1",
    "react-redux": "^5.0.6",
    "react-render-html": "^0.6.0",
    "react-router": "^4.2.0",
    "react-router-dom": "^4.2.2",
    "react-router-redux": "^4.0.8",
    "react-stripe-elements": "^1.6.0",
    "react-tooltip": "^3.4.0",```

@ljharb ljharb self-assigned this Sep 7, 2018
@ljharb
Copy link
Member

ljharb commented Sep 7, 2018

Since we updated from react-with-styles v2 to v3 in v16.4 / #1041, and that brought along a new peer dep requirement, that was a breaking change (cc @lencioni @majapw). I'll add it as a dep + peerDep in both master and in a v16 backport, to fix.

@ljharb ljharb closed this as completed in e61d74c Sep 7, 2018
ljharb added a commit that referenced this issue Sep 7, 2018
…p; this provides it but forwards the peer dep requirement

Fixes #1348.
@ljharb
Copy link
Member

ljharb commented Sep 7, 2018

Published v16.7.1.

@majapw
Copy link
Collaborator

majapw commented Sep 7, 2018

Whoops! Thank you @ljharb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants