Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vertical width #1055

Merged
merged 1 commit into from
Feb 27, 2018
Merged

fix vertical width #1055

merged 1 commit into from
Feb 27, 2018

Conversation

amhunt
Copy link
Contributor

@amhunt amhunt commented Feb 27, 2018

@mariepw's PR removed the condition that the calendar must be horizontal to apply width styling. This broke vertical calendar widths by forcing them to be the width that they would be if they were horizontal and also by making it inline-block.

Here's the problem line: https://github.com/airbnb/react-dates/pull/989/files#diff-883056b4b11263241c339f927e93411bR818

Also, I removed a style object that didn't exist, DayPicker__vertical.

Here's what the calendar looked like:
screen shot 2018-02-27 at 1 37 58 pm

Here's what it should look like:
screen shot 2018-02-27 at 2 47 04 pm

reviewers: @majapw

Copy link
Collaborator

@majapw majapw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems legit to me!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.513% when pulling f11c74e on andrew-cal-fix into 1cb4dd6 on master.

@majapw majapw merged commit 1365e9b into master Feb 27, 2018
@majapw majapw deleted the andrew-cal-fix branch February 27, 2018 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants