add verticalSpacing prop #1096
Merged
add verticalSpacing prop #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
previously requested changes
Apr 3, 2018
src/components/DayPicker.jsx
Outdated
| @@ -66,6 +66,7 @@ const propTypes = forbidExtraProps({ | |||
| verticalHeight: nonNegativeInteger, | |||
| noBorder: PropTypes.bool, | |||
| transitionDuration: nonNegativeInteger, | |||
| verticalSpacing: PropTypes.number, | |||
There was a problem hiding this comment.
should this be non-negative, and an integer?
| @@ -66,6 +66,7 @@ const propTypes = forbidExtraProps({ | |||
| hideKeyboardShortcutsPanel: PropTypes.bool, | |||
| daySize: nonNegativeInteger, | |||
| noBorder: PropTypes.bool, | |||
| verticalSpacing: PropTypes.number, | |||
amhunt
force-pushed
the
andrew-add-vertical-spacing-prop
branch
from
daeebe8
to
a187fe3
Compare
majapw
requested changes
Apr 4, 2018
src/components/CalendarMonth.jsx
Outdated
| @@ -45,6 +45,7 @@ const propTypes = forbidExtraProps({ | |||
| renderDayContents: PropTypes.func, | |||
| firstDayOfWeek: DayOfWeekShape, | |||
| setMonthHeight: PropTypes.func, | |||
| verticalSpacing: nonNegativeInteger, | |||
There was a problem hiding this comment.
I think this name is somewhat overloaded as verticalSpacing in the case of the SDP and DRP signals the margin between the calendar dropdown and the inputs. Could we name this either verticalBorderSpacing to allude to the table or verticalWeekSpacing to allude to the calendar contents?
src/components/CalendarMonth.jsx
Outdated
| {...css( | ||
| !verticalSpacing && styles.CalendarMonth_table, | ||
| verticalSpacing && styles.CalendarMonth_verticalSpacing, | ||
| { borderSpacing: `0px ${verticalSpacing}px` }, |
There was a problem hiding this comment.
Does this get weird when the verticalSpacing is undefined? Like it would try to apply a style of 0px undefinedpx and then it would crap out. I think it would be better to do:
verticalSpacing && {
borderCollapse: 'separate',
borderSpacing: `0px ${verticalSpacing}px`,
},
or
verticalSpacing && styles.CalendarMonth_verticalSpacing,
verticalSpacing && { borderSpacing: `0px ${verticalSpacing}px` },
added 2 commits
April 11, 2018 15:39
amhunt
force-pushed
the
andrew-add-vertical-spacing-prop
branch
from
a187fe3
to
c7ec725
Compare
|
@majapw updated |
majapw
approved these changes
Apr 12, 2018
|
Sweet! Looks great to me! Will merge in and do a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a verticalSpacing prop to DayPickerRangeController, which is passed all the way to
CalendarMonth. This will allow users to add spacing between the rows in the month table.@majapw should we also add
horizontalSpacingwhile we're at it? I don't currently have a use for it, but seems odd to only add one of the two. Maybe I should just add atableBorderSpacingprop with two values:verticalandhorizontal?NB: I also added
showInputsas a declared prop for the wrapper. This was previously throwing a linting error.