Tweak default react-dates styling #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
added
the
semver-patch: fixes/refactors/etc
|
Can you show a before/after screenshot, particularly on the small breakpoint? |
|
Sure @ljharb ! Before (small is second): After (small is second): |
|
Hmm - could we use a shorter arrow instead of removing it entirely? |
|
@ljharb we use a dash (-) sometimes on the site, which is something I considered. Does that seem reasonable? |
|
The important thing for me is that the date doesn't get cut off. |
|
Oh sure, i think any visual separator (altho better if it had a direction) is better than nothing. I agree the dates are the priority. |
|
there’s a Unicode for a triangle pointing right that might fit |
majapw
force-pushed
the
maja-adjust-inputs-to-match-default-airbnb-styles
branch
from
b81f065
to
3d8b054
Compare
|
I like the simplest option here: PTAL @ljharb |
ljharb
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to align the react-dates defaults a bit better with Airbnb's brand. They're pretty subtle tweaks.
I decided to hide the arrow on small inputs because the text was overflowing the area.
to: @garrettberg @ljharb